Dave Halter

Results 359 comments of Dave Halter

I feel like if we can use floating windows or whatever that doesn't modify source code, we just ditch conceal. It has been a pain point for so long. For...

I don't have a strong opinion. I'm probably a sleight bit in favor of separating the settings, but I'm not even sure about that. Feel free to do it however...

Sorry not sure I understand. Do you want me to test it a bit? Just note that I only have VIM. So you need to do the neovim testing yourself.

I'm starting to test it. Are the color changes intentional? I'm totally fine with them, there's just a lot of commits and I'm not sure where some of them come...

I have been testing this for the past few weeks, it looks pretty good. As far as I can see, the signatures colors are still missing (I pulled just now)....

Yeah, I'm using still 7.4 :) Old Ubuntu 16.04. Obviously I'll have to update soon, but it's still in a good shape IMO. It would still be nice I guess...

@blueyed I figured out why the colors are different, no fixes from your side required. This happens because previously we checked with `if exists('g:colors_name')`. Now you use `if hlexists('TabLine')` and...

BTW: While there's obviously conflicts, I'm still interested in this change. If you think this is still in a good shape, we should probably just merge it and do one...

What do you think about using show_call_signatures = 1 for floating windows and 3 for the conceal stuff? In case the VIM version is not good enough, we could fallback...

I would rather not have all those different ways of installing jedi-vim. I would probably just recommend https://github.com/junegunn/vim-plug and remove the other options. @blueyed can decide.