fluxengine icon indicating copy to clipboard operation
fluxengine copied to clipboard

swap_sides default maybe mixed up in Atari settings

Open hpingel opened this issue 4 years ago • 6 comments

Hi @davidgiven!

While browsing your rewritten code the other day I noticed that all the Atari writer configs have swap_sides set to true. If I'm not mistaken swap_sides should always be false except for commodore1581. Maybe a find'n'replace will easily fix this.

hpingel avatar Jul 03 '21 11:07 hpingel

commodore1581 needs swap_sides for writing.

EDIT: Hmmmm, I stand corrected: See https://github.com/davidgiven/fluxengine/pull/310 EDIT2: No, I'm still right.

hpingel avatar Jul 23 '21 17:07 hpingel

Tested in real 1581 floppy drive and this shows: Disk unreadable, so swap_sides is still needed. Will test again with changed sourcecode tomorrow.

hpingel avatar Jul 26 '21 21:07 hpingel

So I think the 1581 is fixed, but I don't know about Atari ST disks. I can write them successfully, but I can't test them as I don't have an Atari ST.

davidgiven avatar Jul 29 '21 16:07 davidgiven

Well, until I find time to set up my only Atari ST that is tucked away somewhere we could kindly ask @keithclark to have a look.

hpingel avatar Jul 29 '21 18:07 hpingel

By the way. I retested commodore1581 tonight and it works well now, both reading and writing.

hpingel avatar Jul 29 '21 20:07 hpingel

I should be able to get hold of an Atari ST for testing! Also, I think all the Atari configs are putzed. I'm pretty sure the 360kB format shouldn't be single-sides 80 track. There's also something very odd going on with swap_sides --- if I set it to false in the config file it still shows up as true in the encoder...

davidgiven avatar Jul 30 '21 21:07 davidgiven