David Gamero

Results 47 comments of David Gamero

the changes seem syntactically small for a gain in compatibility, making this option appealing: @joscha > * Flick the switch to default yes for now, so all test fixtures are...

momentum of discussion has decreased. i would be in favor of merging this PR as-is and following @macjohnny 's suggestion to pursue the remaining items in a future PR to...

ive opened a copy of this PR with the circleCI and merge conflicts resolved at #21560

i see the Azure/login issue was resolved https://github.com/Azure/login/issues/496 is there an issue with aks-set-context here too? or is this now resolved since the login is working again?

i'm testing out a PR on the generator for passing through the signal property on the `RequestContext` type middleware has access to the RequestContext which would allow adding a middleware...

@jannikschaper how do you feel about the middleware injection approach? something like this: ```ts /** * Middleware that adds an abort signal to the request context. * This can be...

thank you for this contribution! can we add an integration test to cover this? adding a new directory in the [integration manifests](https://github.com/Azure/k8s-deploy/tree/main/test/integration/manifests) with two example manifests with different namespaces, and...