pixi-viewport icon indicating copy to clipboard operation
pixi-viewport copied to clipboard

Will it support V8 version?

Open erdezhuang opened this issue 1 year ago • 1 comments

Will it support V8 version?

erdezhuang avatar Jan 29 '24 09:01 erdezhuang

I think some work is ongoing here https://github.com/davidfig/pixi-viewport/pull/468

hlevring avatar Feb 21 '24 02:02 hlevring

I made quick update on-top of https://github.com/davidfig/pixi-viewport/pull/468 to use Pixi v8.0.4 and it seems to work well on my project.

My forked version: https://github.com/WillYuum/pixi-viewport

I'm not sure if I should contribute to the repo in the 468 or just make a pull request directly on main pixi-viewport. So made a pull request here: https://github.com/davidfig/pixi-viewport/pull/483

WillYuum avatar Apr 05 '24 22:04 WillYuum

@davidfig would you mind checking out @WillYuum's PR? This is blocking our upgrade to pixi v8. Thank you!

matthewgapp avatar Apr 08 '24 20:04 matthewgapp

I made quick update on-top of #468 to use Pixi v8.0.4 and it seems to work well on my project.

My forked version: https://github.com/WillYuum/pixi-viewport

I'm not sure if I should contribute to the repo in the 468 or just make a pull request directly on main pixi-viewport. So made a pull request here: #483

Thanks, for me your fork works great with 8.1.0. @davidfig please, consider merging this to the main

VitalyEmelyanov avatar Apr 09 '24 19:04 VitalyEmelyanov

anynone got it working with this line? @VitalyEmelyanov @matthewgapp

app.stage.addChild(viewport)

// Argument of type 'Viewport' is not assignable to parameter of type 'Container'.
//  Type 'Viewport' is missing the following properties from type 'Container': uid, _updateFlags, isRenderGroupRoot, 
// renderGroup, and 101 more.ts(2345)

I am on typescript.

full code looks like this

const app = new Application()
  await app.init({ width: 1080, height: 1080, backgroundColor: 0xffffff })
  document.body.appendChild(app.canvas)

  const viewport = new Viewport({
    screenHeight: window.innerHeight,
    screenWidth: window.innerWidth,
    worldHeight: 1024,
    worldWidth: 1024,
    passiveWheel: false,
    
  })

  app.stage.addChild(viewport)

muhajirdev avatar Apr 13 '24 10:04 muhajirdev

it would be also super nice if viewport can support V8 renderGroup feature. Would give out of the box performance boost.

RecursiveVoid avatar Apr 18 '24 12:04 RecursiveVoid

Anyone having issues, check https://github.com/davidfig/pixi-viewport/issues/487

nightgrey avatar Apr 18 '24 17:04 nightgrey