WebActivator icon indicating copy to clipboard operation
WebActivator copied to clipboard

Searches all subdirectories in the bin folder when compiling list of assemblies

Open akousmata opened this issue 8 years ago • 4 comments

This partially addresses closed issue #21; there are likely better ways of handling this, but this would be a quick fix.

akousmata avatar Dec 15 '16 15:12 akousmata

Does this help when packages are installed parallell to the bin-folder? Or does it only search subfolders to the bin-folder?

xJom avatar Nov 07 '19 10:11 xJom

I haven't built WebActivator in quite some years. If people feel this is important, we can get this change in, but I need to set things up to build this package again.

davidebbo avatar Jun 18 '23 21:06 davidebbo

To put this in context, I originally forked the code and made the change for a project at a firm I worked at 6 years ago where this was needed. It worked fine for our needs and so I PR'd. I don't use this library all that much anymore but for those that do, it might be helpful. Although, I would recommend upgrading to a more modern toolchain at this point.

akousmata avatar Jun 19 '23 01:06 akousmata

Thanks @akousmata for the extra context. I will leave this alone unless other active users are asking for this.

Also, part of the challenge is that it targets Framework 4.0, which is no longer supported. When opening it in VS 2022, it wants to update it to 4.8, and I'm not sure what breaking effects that could have. The targeting pack for 4.0 is no longer available.

From https://learn.microsoft.com/en-us/dotnet/framework/install/guide-for-developers: Starting with Visual Studio 2022, Visual Studio no longer includes .NET Framework components for .NET Framework 4.0 - 4.5.1 because these versions are no longer supported. Visual Studio 2022 and later versions can't build apps that target .NET Framework 4.0 through .NET Framework 4.5.1. To continue building these apps, you can use Visual Studio 2019 or an earlier version.

davidebbo avatar Jun 19 '23 15:06 davidebbo