a-sync-browser icon indicating copy to clipboard operation
a-sync-browser copied to clipboard

Device-Name "null"

Open DrAzraelTod opened this issue 8 years ago • 2 comments

if connected to a device, then you can give it a name that is used remotely. But the global name isn't defined, what results in syncthing (web) displaying the ID instead on prompts - while some frontends (i.e. the other android one) show errors.

So the other android-client displays notifications like "Syncthing Device null want's to share Directory foobar"

DrAzraelTod avatar Dec 16 '16 10:12 DrAzraelTod

this is weird... it should use the android model as device name

private  String getDeviceName() {
    String manufacturer = Build.MANUFACTURER;
    String model = Build.MODEL;
    if (model.startsWith(manufacturer)) {
        return capitalize(model);
    } else {
        return capitalize(manufacturer) + " " + model;
    }
}

I'll add a non-null default. Could you tell me more about your test device, and (if you know) the protocol messages where the device name field is null?

davide-imbriaco avatar Dec 16 '16 11:12 davide-imbriaco

Well, the device i tested on was a Nexus 6p with googles current Android 7.1.1 Beta build

As for protocol messages - i don't have those and i just deinstalled your tool

Further: model-name sounds like a bad Idea to me. My wife and i both had the same phone, as do my parents. I find it plausible that people would want to connect multiple similar devices.

DrAzraelTod avatar Dec 16 '16 11:12 DrAzraelTod