ext-php-rs icon indicating copy to clipboard operation
ext-php-rs copied to clipboard

Published 20 hours ago • verified publisher icon davidcole1340

ci: fix pipeline

Open Xenira opened this issue 1 year ago • 2 comments

Fixed ci as discussed in https://github.com/davidcole1340/ext-php-rs/pull/315

Also had to fix clippy rules that changed and made master fail.

Xenira avatar Aug 07 '24 16:08 Xenira

Not a super fan of removing platform tests tbh, I see that no one has contributed a mac build for clang 18 to the official llvm repo, but maybe there's some other source that could be used for the binaries? Don't have a Mac, but it seems brew offers a clang 18 build...

danog avatar Aug 08 '24 12:08 danog

Just added a clang --version to this and it seems to build with Apple clang version 15.0.0 (clang-1500.3.9.4) (https://github.com/Xenira/ext-php-rs-pipeline-debug/actions/runs/10329884456/job/28598214318#step:10:15).

Adding clang 18 is something I would do in #318.

Apple builds itself are not skipped, They just use the builtin clang (same as Windows), which is the better test imo as that better replicates a user trying to build on their system.

Xenira avatar Aug 10 '24 07:08 Xenira

Hey, would like to get this moving again. Imo we should get the ci working again with as few changes as possible and then focus on getting clang 18 support. @danog

Xenira avatar Sep 16 '24 16:09 Xenira