ext-php-rs icon indicating copy to clipboard operation
ext-php-rs copied to clipboard

Published 20 hours ago • verified publisher icon davidcole1340

fix: Allow to initialise objects

Open cv65kr opened this issue 1 year ago • 5 comments

Solves: https://github.com/davidcole1340/ext-php-rs/issues/262

cv65kr avatar Mar 07 '24 20:03 cv65kr

@cv65kr thanks for the PR! Could you, please rebase on master for the CI?

ptondereau avatar Oct 21 '24 21:10 ptondereau

@ptondereau done

cv65kr avatar Oct 25 '24 11:10 cv65kr

@cv65kr guess you need to run cargo fmt

Xenira avatar Oct 25 '24 11:10 Xenira

@Xenira fixed

cv65kr avatar Oct 25 '24 16:10 cv65kr

LGTM, would like someone with more knowledge of php internals to have a look.

Xenira avatar Oct 25 '24 17:10 Xenira

Resolved by #438

Sorry @cv65kr was new in the project when this came up and then lost sight of it. I still want to say thank you for contributing.

Xenira avatar Jun 05 '25 17:06 Xenira