🎵 Celiz Davidad 🎶
🎵 Celiz Davidad 🎶
Hi! First off, this is awesome. I have been meaning to rewrite some of the longer Redis interactions in LUA but never got around to it. I'm super excited about...
Nice, I'd call 10-20% a little more than slight! :grinning: This looks good to me; the only thing I'm not a huge fan of is all of the `tempN_set` naming....
In fact, it seems like we could get away with two sets maybe? Could be one, but i'd like them to have different names. Something like: ``` ruby liked_set =...
Sounds good, looking forward to it. Thanks again for taking this on!
> last commit is 10~20 times faster (not 10~20%) in my environment. :scream: > And it has some limitation because redis-lua is single thread. so, while running a lua script,...
Not currently. I'd probably accept a PR to make the rating methods take a splatted list of items, though then handling the before/after hooks may end up getting tricky.
Sounds good! Please let me know what you find!
Hmm. I wonder how I can best make Gemfile ordering not matter?
Yeah, the reason is something I'm familiar... The best approach to take was what's been bugging me. Maybe approach 2 is the best? Require that people explicitly bundle an extra...
Hm. As much as I hate the idea of a million little recommendable baby gems (I'd rather be able to just detect a configuration), maybe this IS the best approach....