api-pagination icon indicating copy to clipboard operation
api-pagination copied to clipboard

add cursor based pagination

Open accessd opened this issue 7 years ago • 9 comments

Hi! I think this feature suitable for this gem. Solution based on Kaminari and works independently.

accessd avatar Mar 14 '17 18:03 accessd

👍

zabolotnov87 avatar Mar 15 '17 15:03 zabolotnov87

@davidcelis hi! Could you please review the PR?

zabolotnov87 avatar Mar 29 '17 12:03 zabolotnov87

Hey folks; I'm definitely thinking about this, but there's a lot of potential with this cursor based paginator. I'm weighing the removal of Kaminari and WillPaginate as possible dependencies, as cursor-based pagination works better than LIMIT/OFFSET. This could be a big breaking change for anybody already using the gem, though, so it'd be a major version update.

I'm just weighing my options as to whether this should be an additional paginator, or basically a rewrite of the gem. Thanks!

davidcelis avatar Mar 29 '17 17:03 davidcelis

Hey! Just a idea: api-pagination with cursor based pagination, and api-pagination-adapters which supports Kaminari and WillPaginate. Or even api-pagination-kaminari, api-pagination-will-paginate

accessd avatar Mar 29 '17 17:03 accessd

@accessd That's definitely another possibility, and it'd make it easier to support patches to the kaminari/will_paginate paginators instead of having to backport them to previous versions…

So far I think I like that idea the best. Let me ruminate on it a bit more for a day or two 😄

davidcelis avatar Mar 29 '17 19:03 davidcelis

very anxious to see this PR merged. Any updates?

bcthomas avatar Nov 04 '17 18:11 bcthomas

Looks amazing! Any updates :) ?

jvenezia avatar Feb 28 '18 16:02 jvenezia

Hey @davidcelis did you have the time to think about this? We ended up writing it ourselves, but I would have loved to use this gem feature instead. For me it makes sense to have this along with the existing pagination.

jvenezia avatar Jul 11 '18 13:07 jvenezia

@jvenezia Could you share the library that you wrote since it feels like this library isn't active anymore?

oyeanuj avatar Feb 14 '20 16:02 oyeanuj