api-pagination
api-pagination copied to clipboard
add cursor based pagination
Hi! I think this feature suitable for this gem. Solution based on Kaminari and works independently.
👍
@davidcelis hi! Could you please review the PR?
Hey folks; I'm definitely thinking about this, but there's a lot of potential with this cursor based paginator. I'm weighing the removal of Kaminari and WillPaginate as possible dependencies, as cursor-based pagination works better than LIMIT/OFFSET. This could be a big breaking change for anybody already using the gem, though, so it'd be a major version update.
I'm just weighing my options as to whether this should be an additional paginator, or basically a rewrite of the gem. Thanks!
Hey! Just a idea: api-pagination
with cursor based pagination, and api-pagination-adapters
which supports Kaminari and WillPaginate. Or even api-pagination-kaminari
, api-pagination-will-paginate
@accessd That's definitely another possibility, and it'd make it easier to support patches to the kaminari/will_paginate paginators instead of having to backport them to previous versions…
So far I think I like that idea the best. Let me ruminate on it a bit more for a day or two 😄
very anxious to see this PR merged. Any updates?
Looks amazing! Any updates :) ?
Hey @davidcelis did you have the time to think about this? We ended up writing it ourselves, but I would have loved to use this gem feature instead. For me it makes sense to have this along with the existing pagination.
@jvenezia Could you share the library that you wrote since it feels like this library isn't active anymore?