astring icon indicating copy to clipboard operation
astring copied to clipboard

Add support to Estree import attributes

Open aralroca opened this issue 1 year ago • 1 comments

Import attributes is now already in runtimes as Bun for macros and is in stage 3 in Estree, I think it would be nice to support it in astring.

References:

  • TC39: https://github.com/tc39/proposal-import-attributes
  • Estree: https://github.com/estree/estree/blob/master/stage3/import-attributes.md

aralroca avatar Mar 20 '24 10:03 aralroca

True, let's add that.

davidbonnet avatar Jun 13 '24 16:06 davidbonnet

@davidbonnet I wanted to try to contribute but I am having problems running the tests:

Screenshot 2024-07-22 at 16 51 57

The only thing I have done is npm i && npm test, what I'm missing? As a suggestion, it would be nice to create a CONTRIBUTING.md 😊 file.

BTW; this https://github.com/meriyah/meriyah/pull/280 is the PR of meriyah to support import attributes. It will probably be available in the next release.

aralroca avatar Jul 22 '24 14:07 aralroca

This is fixed !

aralroca avatar Aug 25 '24 21:08 aralroca