crosslingual-coreference icon indicating copy to clipboard operation
crosslingual-coreference copied to clipboard

Support for Spacy 3.4.0

Open kodymoodley opened this issue 2 years ago • 8 comments

Hi, I would like to use this nice package for Dutch language models that only work with Spacy 3.4.0+. How difficult would it be to support spacy 3.4.0?

kodymoodley avatar Apr 21 '23 15:04 kodymoodley

@davidberenstein1957 is there a reason why the pyprojct toml locks the spacy version to 3.1.X? (the readme even mentions using spacy 3.3+)

stdweird avatar Apr 09 '24 07:04 stdweird

Hi @stdweird @kodymoodley, I've not been too involved with maintaining this package. I will block some time to fix this coming weekend, but feel free to create a PR on top of this yourself too. I've also been wanting to fine-tune a coref model using another new package but have not gotten around to doing that as yet.

davidberenstein1957 avatar Apr 09 '24 08:04 davidberenstein1957

@davidberenstein1957 do you suspect that we need to lock spacy (eg > 3.0, < 3.8 or simpy allow all 3.X). and if we can run the tests, it should be enough?

stdweird avatar Apr 09 '24 08:04 stdweird

Yes it should be.

davidberenstein1957 avatar Apr 09 '24 08:04 davidberenstein1957

@davidberenstein1957 Problem is with project allennlp which was ended on the version 2.10.1 with depends on spacy (>=2.1.0,<3.4)

poetry lock: SolverProblemError Because crosslingual-coreference depends on allennlp (==2.10.1) which depends on spacy (>=2.1.0,<3.4), spacy is required.

matesaki avatar Apr 16 '24 10:04 matesaki

Ahh shit. I knew that in my subconscience. I will fine-tune a new model and wrap out allennlp with fast-coref :)

davidberenstein1957 avatar Apr 17 '24 15:04 davidberenstein1957

Great to hear this project is still alive! Were you able to make any progress on this?

hardchor avatar May 08 '24 17:05 hardchor

Yes I was but I'm currently on holidays. I've prepped the data and will run some training later this month. 🙂El 9 may 2024, a las 2:43, Burkhard Reffeling @.***> escribió: Great to hear this project is still alive! Were you able to make any progress on this?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

davidberenstein1957 avatar May 08 '24 22:05 davidberenstein1957