classy-classification icon indicating copy to clipboard operation
classy-classification copied to clipboard

Add mulit-label support

Open PepijnBoers opened this issue 2 years ago • 9 comments

Extends the Spacy classy skeleton to support multi-label classification, using a multi-layer perceptron.

PepijnBoers avatar May 23 '22 15:05 PepijnBoers

@PepijnBoers didn't you finish yet? Or was closing it a mistake?

davidberenstein1957 avatar May 24 '22 05:05 davidberenstein1957

@davidberenstein1957 I was creating the feature for personal use and accidentally created the PR on your repo istd of my fork. But if you'd be interested in supporting multi-label classification in the main repo, I could make an actual PR. Let me know!

PepijnBoers avatar May 24 '22 09:05 PepijnBoers

Yes please do!

On Tue, May 24, 2022 at 11:07 AM Pepijn Boers @.***> wrote:

@davidberenstein1957 https://github.com/davidberenstein1957 I was creating the feature for personal use and accidentally created the PR on your repo istd of my fork. But if you'd be interested in supporting multi-label classification in the main repo, I could make an actual PR. Let me know!

— Reply to this email directly, view it on GitHub https://github.com/Pandora-Intelligence/classy-classification/pull/7#issuecomment-1135613112, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZHZA5ZY6VRS6P73IGFUDVLSL5BANCNFSM5WWH5ZFQ . You are receiving this because you were mentioned.Message ID: @.***>

davidberenstein1957 avatar May 24 '22 09:05 davidberenstein1957

Ok, I'll probably work on it this week.

PepijnBoers avatar May 24 '22 09:05 PepijnBoers

@PepijnBoers could you take a look at the formatting standards? Also, please provide some tests, and context/example in the readme.

davidberenstein1957 avatar May 25 '22 07:05 davidberenstein1957

@davidberenstein1957 ready for review.

PepijnBoers avatar May 28 '22 09:05 PepijnBoers

@davidberenstein1957 ready for review.

What is the status on this?

PepijnBoers avatar Sep 12 '22 08:09 PepijnBoers

Hey Pepijn,

Sorry. I haven't really worked on my packages that much due to some busy months. I'll work on it during the coming weeks.

Regards, David

On Mon, Sep 12, 2022 at 10:06 AM Pepijn Boers @.***> wrote:

@davidberenstein1957 https://github.com/davidberenstein1957 ready for review.

What is the status on this?

— Reply to this email directly, view it on GitHub https://github.com/Pandora-Intelligence/classy-classification/pull/7#issuecomment-1243364352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZHZBQQZH3WSLJS3BLNXLV53QA3ANCNFSM5WWH5ZFQ . You are receiving this because you were mentioned.Message ID: @.***>

davidberenstein1957 avatar Sep 12 '22 08:09 davidberenstein1957

Awesome! please take a look at my formatting preferences.

On Tue, May 24, 2022 at 11:26 AM Pepijn Boers @.***> wrote:

Ok, I'll probably work on it this week.

— Reply to this email directly, view it on GitHub https://github.com/Pandora-Intelligence/classy-classification/pull/7#issuecomment-1135642695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAZHZF55BXLIU7U7T2X543VLSOCXANCNFSM5WWH5ZFQ . You are receiving this because you were mentioned.Message ID: @.***>

davidberenstein1957 avatar Oct 11 '22 08:10 davidberenstein1957

Hey, any updates on this? When is this going to be integrated?

miroslavtushev avatar Oct 26 '22 17:10 miroslavtushev

@PepijnBoers I took a while from my side, but thanks a lot for your contribution! I will fine-tune this today and add it to the next release.

davidberenstein1957 avatar Nov 01 '22 10:11 davidberenstein1957

@PepijnBoers you can take a look at my initial refactoring. I expect to be able to wrap up the entire release coming Friday.

davidberenstein1957 avatar Nov 01 '22 14:11 davidberenstein1957

@miroslavtushev See the comment above.

davidberenstein1957 avatar Nov 01 '22 14:11 davidberenstein1957