davidben
Improve Javascript for zwrite.js
In particular, it creates a new iframe every time you send something; it should really delete those at some point. Also, if you get an error, four things get logged to the console but nothing happens on the page.
This is kind of halfway between an actual bug report and zwrite davidben.
Yeah, it's labelled a proof-of-concept for a reason. :-) There's no UI. But it deletes the iframe in the callback. It also doesn't re-request tickets if already requested them once this page.
But yeah, we should consider using some of the postMessage libraries that Mozilla wrote for BrowserID. Well, really they should have added MessagePorts to begin with, but only WebKit supports those right now.
Does it not delete them if it errors out or something? I'd check this if I were near a computer now, but it was definitely not removing them.
On Friday, June 15, 2012, David Benjamin wrote:
Yeah, it's labelled a proof-of-concept for a reason. :-) There's no UI. But it deletes the iframe in the callback. It also doesn't re-request tickets if already requested them once this page.
But yeah, we should consider using some of the postMessage libraries that Mozilla wrote for BrowserID. Well, really they should have added MessagePorts to begin with, but only WebKit supports those right now.
Reply to this email directly or view it on GitHub: https://github.com/davidben/webathena/issues/17#issuecomment-6369135
~132.905~
It deletes them upon getting a reply to the postMessage. If it never even gets one of those, then it probably doesn't. We could maybe listen for some appropriate event on the iframe for noting that the page failed to load. Or use BrowserID's libraries, since we apparently need to change this to deal with popup blockers anyway.