nspluginwrapper icon indicating copy to clipboard operation
nspluginwrapper copied to clipboard

build failure due to including gthread.h directly

Open anssih opened this issue 14 years ago • 1 comments

/usr/include/glib-2.0/glib/gthread.h:28:2: error: #error "Only <glib.h> can be included directly."

This can be fixed trivially with:

Index: nspluginwrapper-1.4.4/src/npw-player.c
===================================================================
--- nspluginwrapper-1.4.4/src/npw-player.c
+++ nspluginwrapper-1.4.4/src/npw-player.c      2011-12-16 05:22:25.672747496 +0200
@@ -24,8 +24,6 @@
 #include <dlfcn.h>
 #include <unistd.h>
 #include <glib.h>
-#include <glib/gstdio.h>
-#include <glib/gthread.h>
 #include <gtk/gtk.h>
 #include <gdk/gdkx.h>
 #include <gdk/gdkkeysyms.h>

anssih avatar Dec 16 '11 03:12 anssih

Actually you can't remove gstdio.h; it's intentionally separate so including glib.h does not pull stdio.h and everything and g_chdir is apparently defined in there. gthread.h should indeed be punted through. Thanks! Fixed.

(Sorry for the late response; I'm traveling and my Internet access is spotty.)

davidben avatar Dec 29 '11 13:12 davidben