python-in-the-morning
python-in-the-morning copied to clipboard
davidbegin
Code Review of Forked Library Lighthouse-Lambda
Original Library:
https://github.com/joytocode/lighthouse-lambda
Problem:
Stops working after Node 8.10 (Can't even spin up Node8.10 on AWS anymore)and Lighthouse 3.1
My Solution:
https://github.com/AlanSwenson/lighthouse-lambda
- Fork that uses chrome-aws-lambda instead of @serverless-chrome/lambda/dist/headless-chromium
- Works on Node 10 and 12 uses Lighthouse 5.6
- Updated Packages with Known Vulnerabilities
Notes:
- Still needs updated Readme
Questions:
What do I do now to 'Polish' this update? What if it doesn't get merged to the original repo? Does is make sense to add a Makefile for docker commands/ testing?
I don't know enough about Node or Lambda to review, but this might be helpful: if you're asking for a third-party to review changes you've made on Github, you can use https://github.com/<account>/<repo>/compare/<commit1>..<commit2>?diff=split
In this case: https://github.com/AlanSwenson/lighthouse-lambda/compare/a96a78f467792ffbba87ad54ec88a257505849d7...eb3a9d90da35cd236f6ab29dea18acc1902d0dd9?diff=split
