python-in-the-morning icon indicating copy to clipboard operation
python-in-the-morning copied to clipboard

Code review request

Open Caleb-T-Owens opened this issue 5 years ago • 7 comments

Could I have a code review for my little game jam repo, please? It would be nice if it was a time when I was watching a stream but that doesn't really matter because I can watch back the vod later.

Most of the important code is in renderer.js

coord.js and texture.js are little struct classes. If there were structs in js, they would be structs.

entity.js, renderer.js, and sound.js are regular classes.

sounds.js and textures.js are objects that hold texture and sound objects.

helper.js and playerHelper are helper classes that contain functions that don't belong anywhere else.

Caleb-T-Owens avatar Mar 03 '20 15:03 Caleb-T-Owens

I'm no JS expert and am probably using way old techniques, but I'll take a look. It would be good to ad some instructions on how to run in README

davidbegin avatar Mar 05 '20 03:03 davidbegin

@davidbegin Ok

Caleb-T-Owens avatar Mar 05 '20 15:03 Caleb-T-Owens

I have added the instructions on how to run it and some information about knowen quirks

Caleb-T-Owens avatar Mar 05 '20 16:03 Caleb-T-Owens

Thanks, already better! But to be honest for the harder directions you are going to need more steps or no one is going to figure it out! Remember programmers are lazy! This our gift and our curse. You don't tell me what to install, how to install (for at least your system!) , and how to run, I'm not going to figure it out. I'm going to move onto another project.

While I'm still no JS expert, I'll see how looking at it on stream Saturday when I have a JS expert for co-stream!

davidbegin avatar Mar 06 '20 04:03 davidbegin

eek! A professional JS dev!

Caleb-T-Owens avatar Mar 06 '20 11:03 Caleb-T-Owens

I made some updates to my "game" so the first message in my issue is slightly out of date

the thing that has changed is that playerHelper.js has turned into player.js and contains the Player class which contains the player controller that I made today.

Caleb-T-Owens avatar Mar 06 '20 23:03 Caleb-T-Owens

I also made better install instructions

Caleb-T-Owens avatar Mar 07 '20 08:03 Caleb-T-Owens