David Barsky

Results 134 comments of David Barsky

> You might need to rebase to fix the CI. > > > > @davidbarsky what VS Code are you on? 1.78 right now, but 1.82 in a week or...

Hey @jhgg! I've hacked something together yesterday on a whim and only realized today that that you claimed this issue. I'm not sure how you'd like to tackle this, but...

> ...and tracing-tree assumes that there will only be one line? That's correct, yeah. I think that resolving this would take a _lot_ of effort.

ah, that doesn't seem great. well, we'd accept a PR fixing this, if you have the time!

Can you replicate this if you set a dependency on `tracing-core` of `0.1.32` in your `Cargo.toml`? Is there a branch where I can try and replicate this? (I'm guessing is...

Oh, thank you for the minimal reproduction—that is a bit odd. I bet we're doing something silly when interacting with `log`.

> #2880 is merged. Once released, it should close this issue. We'd need to port it to master as well, yes? EDIT: yes, we will. 2880 only targeted v0.1.x.

Thanks for opening this PR! Unfortunately, this feature was added [in 1.71](https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-171-2023-07-13), which is substantially above our MSRV. I don't think we can merge this PR at this time, unfortunately....

Oh wow, thanks for opening this PR and sorry for the delay in responding. I haven't gone over the benchmarks yet (I'd like to rerun them on a less noisy...

Sorry, it took me a second to understand what was happening, but I can see how `SubscriberInitExt::{init, try_init}` is problematic in your case. I'm not entirely sure how we should...