David Barratt

Results 38 comments of David Barratt

Sorry, I had to create a new pull request. my original one attempted to add PSR-0 support, which involved changing more things than necessary. I've just added a simple composer.json...

I hope you might reconsider, if you are using a [multi-stage Dockerfile for testing](https://docs.docker.com/language/nodejs/run-tests/#multi-stage-dockerfile-for-testing), requiring git to work properly means the entire layer is uncachable since you have to copy...

> In what way does it not? Objects that aren't hashes will return the `to_s` value. Indeed, the [documentation](https://ruby-doc.org/stdlib-2.6.3/libdoc/json/rdoc/JSON.html#module-JSON-label-Generating+JSON) says: > `JSON.generate` only allows objects or arrays to be converted...

> So a fix could be `JSON.generate(obj.respond_to?(:to_json) ? data.to_json : data)`? That seems reasonable. I believe `to_json` returns a string, so I don't think passing it into `JSON.generate()` would work....

@gkellogg Thank you so much for your quick response. I was assuming that `location` would be of type `@id`. I wasn't sure if it was better for API consumers if...

I think it might actually have something to do with how the constructor deals with `primaryKey` and default values, but I'll dig in some more and find out.

I found out that when calling `set()` for the first time without a `primaryKey` (as is done in the constructor) will set the primary key's default value, then when you...

uhh, I wouldn't mind as long as I use it. :) perhaps a new "org" on github should be created?