David Anthoff comments

Results 1184 comments of


                                            David Anthoff

The working directory inside of a `@testitem` block does not point to the package test directory or root directory.

So the main question is: package dir or folder of the file in which the test is defined :) I had a Slack question on that, and folks came down...

The working directory inside of a `@testitem` block does not point to the package test directory or root directory.

Haha, you mean having a different choice in VS Code and the command line runner ;) Not really ideal, I would say :)

The working directory inside of a `@testitem` block does not point to the package test directory or root directory.

Let's make it the folder of the file where the test is defined. If at some point in the future we want to allow tests outside of packages that would...

The working directory inside of a `@testitem` block does not point to the package test directory or root directory.

I think this is resolved now

User-experience outside of VS Code

> Would PRs for such things be welcome? Yes! The current non-VS Code experience really is the absolute bare minimum. I was primarily focused on the VS Code experience but...

Doctests as testitem?

We should probably just try to detect doc tests statically and then treat them as a special kind of test item, or something like that...

File gets parsed correctly, but the offset information indicating symbol location seems wrong

To get the character index for a given byte index for a string, do this: `length(s, 1, byte_index)`. Julia string handling, especially when it comes to Unicode, is good, but...

File gets parsed correctly, but the offset information indicating symbol location seems wrong

Very nice!

Provide some kind of "coverage" warning/error if a test file includes code outside a testitem

Another option would be to have a "strict test file" option. If that is enabled, if there is a Julia file that has anything _other_ than `@testitem` or `@testsetup` in...

Random Roslyn link

[This](https://github.com/Microsoft/tolerant-php-parser/blob/master/docs/HowItWorks.md) might also be interesting, it describes how they got their error tolerant parser to work.