David Andreoletti

Results 84 comments of David Andreoletti

> I will look at it. It looks like we dont have enough reviewers and I am trying to do it as much as I can in my free time,...

@BKPepe This PR needs your input: https://github.com/openwrt/packages/pull/22942#issuecomment-1911997425

> I agree that we should do this, but boy, this is a gnarly change. I am a user of [gitui](https://github.com/extrawurst/gitui), itself relying on libgit2 and would like to highlight...

@xabolcs With https://github.com/badaix/snapos/pull/29, snapcast can be built again for OpenWRT 23.05 and current SNAPSHOT. Have you tried this PR with OpenWRT 23.05 yet ? I am keen to help test...

> Is it recommended by OpenWRT to migrate to procd? @badaix Yes, `procd` is [THE startup/process management facility for OpenWRT.](https://openwrt.org/docs/techref/procd)

> But I use the init files @xabolcs Do you mean the init files using procd (from this PR) were copied to your OpenWRT 23.05/snapshot device and are working as...

@xabolcs Thanks! @badaix: @xabolcs confirmed the procd enabled init files in this PR are working on the latest OpenWRT stable and snapshot release. Benefits for snapcast: better integration with OpenWRT's...

@badaix This PR will take 4 min of your time max to [review its usefullness](https://github.com/badaix/snapos/pull/7#issuecomment-2028101105)/merge.

@kerta1n / @bw118 With #29 now merged in, `snapcast` packages can be built successfully for OpenWRT 23.05 and SNAPSHOT. Give it a go :-)