David Alber
David Alber
I'm with you regarding state. It's kind of a big line to cross. GitHub has an endpoint to retrieve [events for an issue](https://developer.github.com/v3/issues/events/#list-events-for-an-issue). That shows events for reviewers added and...
_Apologies. This is a long comment. There's a lot of context that goes with it._ So...way back in #38 it was identified that some users were, oddly, not appearing in...
> That must mean that Highfive is greeting repeat contributors all of the time in rust-lang/rust. (You probably already see this, but I don't pay very close attention there right...
The [commit search API](https://developer.github.com/v3/search/#search-commits) looks like it does what Highfive really wants (easily determine if a given user has commits on the default branch). Like the `author_association` field, however, it...
> Given that GH can see this because it gives you the option of highlighting PRs from first-time contributors, I assume there must be API for it. Probably commit search...
There's at least two issues here: 1. The webhook in each of the repositories using Highfive is not configured to send review events to Highfive. 1. Even if Highfive were...
For exposition, do you have a link to an issue where you used r? in a review comment?
Do you expect this to happen when the changes are requested by anyone or just the assigned reviewer?
A similar idea is mentioned in #39. It's suggested there that when assignment fails Highfive should pick a different random reviewer. On a different note, brson was in the global...
> I expect we won't want to hand out creds to that server I completely understand that. Is the concern about giving non-Mozilla access to the machine, the @rust-highfive OAuth...