David Bar-On

Results 53 issues of David Bar-On

Suggested fix for issue #4273. The main change is in `add_misformatted_file()` to use the proper newline styles in each of the `original/expected` fields in each `MismatchedBlock`. The original code's newline...

p-low
pr-not-reviewed
pr-targeting-2.0

Suggest fix for issue #4499 - `skip` attribute in `struct impl` and in other cases. The changes are basically to all calls to `push_skipped_with_span()` where the 2nd parameter was `x.span`....

p-low
pr-follow-up-review-pending
pr-targeting-2.0

Add handling of comments between Trait Generics and Bounds by using rewrite_assign_rhs_with_comments() (one of the cases identified in #4626 discussion). Also added workaround for an issue that a comment before...

p-low
pr-targeting-2.0

Closes #4824 The suggested fix is in two code changes done for Version Two - by adding `trim_start()` before passing a comments string to `rewrite_comment()`. A more robust fix may...

pr-follow-up-review-pending

Closes #5489 Suggested fix for #5489 - allow macro `metavariable` as attribute value. In addition, allow also `CONST` as attribute value. The suggested fix is actually a workaround to a...

pr-not-reviewed

Backport of suggested R2 changes for handling indentation of comments between assignment rhs and lhs, taken from different R2 PRs/commits. Not all changes were merged into R2, so this is...

pr-not-reviewed

Fixes #11889 Suggested fix for preventing error about overriding private functions by inheriting/other contracts. The fix is based on the previous suggested fix by PR #13328, with the enhancements required...

external contribution :star:

Fixes #10155 Suggested solution for remove warning messages that Free functions shadow Interface functions. As I wrote in [this comment](https://github.com/ethereum/solidity/issues/10155#issuecomment-1565633372), it may be considered to extended the solution to other...

external contribution :star:

* Version of iperf3 (or development branch, such as `master` or `3.1-STABLE`) to which this pull request applies: master * Issues fixed (if any): #1696 * Brief description of code...

* Version of iperf3 (or development branch, such as `master` or `3.1-STABLE`) to which this pull request applies: master * Issues fixed (if any): #819 * Brief description of code...