axum-tracing-opentelemetry icon indicating copy to clipboard operation
axum-tracing-opentelemetry copied to clipboard

tonic-tracing-opentelemetry: update tracing-opentelemetry-instrumentation-sdk to 0.16

Open nshalman opened this issue 1 year ago • 2 comments

nshalman avatar Jan 12 '24 15:01 nshalman

FYI, I disconnected the crate for tonic from the workspace until tonic migrate/upgrade to hyper 1.0,... (http, axum). This disconnection allows to upgrade the other crates of the workspace. It's why the dependency to tracing-opentelemetry-instrumentation-sdk for the tonic-tracing-opentelemtry was not upgraded (hidden conflict on transitive dependencies).

Thank you for the PR.

EDIT: see https://github.com/davidB/tracing-opentelemetry-instrumentation-sdk/issues/115#issuecomment-1857566394

davidB avatar Jan 12 '24 16:01 davidB

FYI, I disconnected the crate for tonic from the workspace until tonic migrate/upgrade to hyper 1.0,... (http, axum). This disconnection allows to upgrade the other crates of the workspace. It's why the dependency to tracing-opentelemetry-instrumentation-sdk for the tonic-tracing-opentelemtry was not upgraded (hidden conflict on transitive dependencies).

Thank you for the PR.

Thank you for the explanation. I'm hunting down a quirk that I thought might be fixed by updating libraries, but instead I'll open an issue.

nshalman avatar Jan 12 '24 20:01 nshalman