david942j

Results 43 comments of david942j

Thanks for the contribution! For unknown reasons the test seems hang on CI, will see what happened when the job aborts.

Weird, it seems caused by this PR: https://github.com/david942j/seccomp-tools/runs/6949456039?check_suite_focus=true ``` Randomized with seed 27005 Error: ............................................[ERROR] No seccomp filters installed Error: The operation was canceled. ``` The last message before hang...

Thanks for the investigation! > no filters installed for process Yes I prefer to differentiate the two cases. Like the test case shows if there is only one filter installed...

Thanks for the PR! Only one feedback that I want the coverage be kept as 100%, please enhance the tests to cover the new line.

How about adding a Dockerfile that could include all needed toolchain?

You don't need a Ruby gem, just provide a Dockerfile under spec/files along with a README to describe the sequence of commands to generate the riscv binary (i.e. docker build;...

Ruby 2.4 reaches EOL in last year, I would say it's time to drop Ruby 2.4 support. So I prefer you to remove 'being' here and I will update gemspec...

Came here for the same question. Hope this nice badge could come back!