David Chiu

Results 33 comments of David Chiu

Sorry @janeyx99, I mistakenly thought the failures might have been fixed, so I rebased onto the main branch. However, after investigating the error message, I found that it was caused...

Should I keep the parameter name `d_p_list`? None of the affected functions are exposed to external users. ![image](https://github.com/pytorch/pytorch/assets/51911434/615e5acd-021f-44e1-83c4-a8b6318365a3)

> > Should I keep the parameter name `d_p_list`? None of the affected functions are exposed to external users. > > Yes, we should keep the name. sgd is publicly...

> > Should I keep the parameter name `d_p_list`? None of the affected functions are exposed to external users. > > Yes, we should keep the name. sgd is publicly...

> looks like there are merge conflicts now :/ fixed

> Please run lintrunner locally to ensure lint passes for the next commit (and usually before pushing). Getting lintrunner locally is pretty simple: just > > ``` > pip install...

Hi, @janeyx99, I have tried to fix the code and add a test. However, the test passed on both the original code and the fixed code on my device (CPU-only)....