David Charles Gibbs

Results 51 comments of David Charles Gibbs

> Haha, OK that was what the Gauva dependency management was for :-)

> Do you know which plugin triggers this? It is a transitive dependency of "org.apache.maven:maven-core". scope of guava is now "provided" rather than "test" to match the expected scope of...

> Is it possible that the name of the new module is changed to something like `quickfixj-...` to have all module names follow the same schema? Yes that makes sense,...

> There seems to be some duplication inside the new module as far as the Orchestra logo and the readme is concerned. The parent contains the same readme and logo...

@chrjohn I think I have updated the PR to conform to your comments. Please re-run the build as 2 macOS steps failed. Thanks and regards. Dave

@chrjohn Could you let me know please if you are happy with the changes as per your comments ? If so I will also update [PR 460 ](https://github.com/quickfix-j/quickfixj/pull/460)

@chrjohn @donmendelson It's a good point. There a few dimensions to the question. To help me make a case, I'll restate how I think using QFJ may work in the...

Yes we need to keep the Apache License but that is the extent of the complexity. It’s a good angle for having the separate repo. They should have only the...

> For now I've created https://github.com/quickfix-j/quickfixj-orchestra but still need to remove everything that we don't need and adapt package names and so on... Do you want me to do that...

@donmendelson @chrjohn I created a first cut for updates to https://github.com/quickfix-j/quickfixj-orchestra and put a short explanation about why I pruned the repository. Happy New Year!