angular-npm-module-seed icon indicating copy to clipboard operation
angular-npm-module-seed copied to clipboard

Does this still work with Angular 4?

Open austinthedeveloper opened this issue 6 years ago • 5 comments

I've been messing around with this project and no matter what I do, I'm getting this error when importing to my Angular 4+ project:

Unexpected value 'CountToModule' imported by the module 'AppModule'. Please add a @NgModule annotation.

I've tried getting this to work 2 different ways:

  • Build the original project with no modifications, link, and import the module into the project
  • Update the Angular packages to >=4.0.0, typescript to ~2.3.3, and reflect-metadata to ^0.1.10. The build succeeds. Run npm link on the dist folder.

Both are imported in the project the same way: import { CountToModule } from 'angular-count-to';

@NgModule({
  ...
  imports [CountToModule]
  ...
});

Tslint-wise, there's no error because it's imported correctly. But as soon as I run ng-serve, I get the error above.

Are there additional instructions on how to import a module?

austinthedeveloper avatar Sep 26 '17 19:09 austinthedeveloper

Yeah, same issue here! I watched this issue while using node > version 8. WIth 7.9 all seems fine. What was your node setup @austinthedeveloper ?

alubeck avatar Nov 03 '17 20:11 alubeck

I'm pretty sure it has to do with differences between Angular 2 and 4. I ended up going with another starter that does basically the same thing as this repo but works with 4. When I copy/pasted my exact code over to the new repo, it all worked.

austinthedeveloper avatar Nov 03 '17 21:11 austinthedeveloper

Thanks for reporting, @austinthedeveloper and @alubeck. This seed project is outdated indeed and probably some maintenance work needs to be done on my side for the new Angular / Node versions

davguij avatar Nov 04 '17 11:11 davguij

@austinthedeveloper Could you send me the link of the other project starter repo please? Thanks

zt1983811 avatar Nov 22 '17 21:11 zt1983811

https://github.com/robisim74/angular-library-starter

I've built 2 modules with this one.

austinthedeveloper avatar Nov 22 '17 22:11 austinthedeveloper