Dav Glass

Results 67 comments of Dav Glass

I'd likely accept a Pull Request for this..

Can I get an example module please? The custom license detection/URL parsing was a user PR and I'm not all that familiar with it.

Thanks for the issue, I'll have to think on this one.. This was added because it can cause an infinite loop if there are circular dependencies. The issue here is...

Yes, this needs to be handled. Ideally all license checking should be via `spdxSatisfies`, I've just had no time to look into it 😞

That's odd, the only place that it sets the `start` is like this: ```js parsed.start = parsed.start || process.cwd() ``` So if `start` is passed, it should work off that...

Hey -- Thanks for the kind words :) I've updated the readme with the fuse block and fuses that I used to build my version. I added the fuses because...

Interesting, I've never formatted that line before. The original commit is only including the content of the license file: https://github.com/davglass/license-checker/blob/dd6ecab1a7b1354c4d1d001491f58dbe0f5e3e63/lib/index.js#L167 I'll have to see what the difference in logic is...

That version is very old and doesn't contain proper license info: http://registry.npmjs.org/colors/0.6.2 If you use a modern version it reports properly: ``` └─ [email protected] ├─ licenses: MIT ├─ repository: https://github.com/Marak/colors.js...

Sure, it does make sense to always return an `Array` or `null`.

I'm not sure this is an issue with `license-checker` itself or if it's the `spdx-satisfies` module. The line that throws the error is: ```js } else if (spdxCorrect(license) && spdxSatisfies(spdxCorrect(license),...