devcert
devcert copied to clipboard
davewasmer
feat(subject_alt_names): Allow multiple subject_alt_names
Related to: https://github.com/davewasmer/devcert/issues/33 allows a user to pass in multiple domain names for one certificate without introducing breaking API changes.
This would be a welcome addition. Might also be a good idea to allow IP addresses
@camsjams this project is sporadically maintained. I'm not even sure the author of this PR is even getting notifications
I guess we can try pinging @jamsea :man_shrugging:.
If that doesn't work, maybe it would be worthwhile to fork the changes, submit a new PR, and ping zetlen.
@Js-Brecht sorry! All my notifications were going through an email filter 🤦♂ I just noticed now because I saw a push notification on my phone. I'll take a read now
@camsjams if you're free this week and want to take this over that'd be helpful. I'm on another project now so I wouldn't be able to get this until next week. I'll fix notifications so I'm available though
I can take this on, I will probably submit a new PR with the suggestions applied and more minimal changes. I was successfully able to use this feature add to create multiple alt names locally so I am happy to get this merged into the main branch.
Maintainer here. I prefer to call it "periodically maintained". Most of the codebase is mature; additional fun stuff would require a big refactor, which I'd probably put in a new library.
But even bugfixes require a pretty big regression, using multiple VMs; a lot of the code directly touches OS features, so the only useful testing is end-to-end. So that slows down the processing of PRs somewhat.
Thanks very much in advance for your help, @camsjams. As soon as you've updated this, I can get it merged fast.
I prefer to call it "periodically maintained".
No offense meant, @zetlen. You guys have done a great job on this project, and the fact that it needs little maintenance is an excellent indicator of that.
Here is the new https://github.com/davewasmer/devcert/pull/52, we can probably close this current PR in favor of #52 if everyone here agrees.
Basically the same changes that @jamsea had made with the code review comments from @zetlen
Let's close this one as I have branched from @jamsea code (thanks!) and this PR has been remerged again with Master following some code review.
See new PR here: https://github.com/davewasmer/devcert/pull/52
...Might also be a good idea to allow IP addresses
I've have submitted a new PR (#91) with exactly this feature. I hope the maintainer could merge it someday... 🤞
