helium-tax
helium-tax copied to clipboard
Include hotspots which no longer belong to an account
Problem
As reported on https://github.com/davetapley/helium-tax/discussions/46#discussioncomment-1893671
if you put in a wallet address to run a query the results appear to only be for the miner(s) in the wallet currently. If for example, you had 2 miners in a wallet in 2020 but have since sold one, when you run the 2020 report by wallet address you will only get a list of transactions for the single miner still in the original wallet address today.
List comes from ⬇️ but can't get previously owned due to https://github.com/helium/blockchain-http/issues/395 https://github.com/davetapley/helium-tax/blob/2983cd395dfc2b2ac252eb6b2d2d0948b5161bd5/tax.js#L17
Workaround
As suggested here:
It’s a known issue. Always export before transfer.
The other wallet has the same (opposite) problem. It will show all earnings for its current hotspot, some may belong to the previous wallet.
@carlcom yikes, that's even worse. Thanks for reporting it 😱
I have a horrible feeling I'm going to have to re-learn Erlang, because AFAICT this is blocked until the API supports it in https://github.com/helium/blockchain-http/issues/395 😬