ansible-nas
ansible-nas copied to clipboard
Add: Calibre eBook Manager
What this PR does / why we need it:
Add Calibre eBook Manager
Which issue (if any) this PR fixes:
Fixes #297
Any other useful info:
- I've been running this locally for about two months.
- Passing the
security_optsinto the docker container fixed this recent error: https://github.com/linuxserver/docker-calibre/issues/102. Glances and netdata are the only other roles to use security options. - Verify I correctly added the molecule tests.
- The implementation of mounting
- "{{ calibre_data_directory }}/data:/data"inroles/calibre/tasks/main.ymlworks, but it should be checked. The may be a better way to expose the Calibre Database Directory to thecalibredocker container. - I would like to see the application_ports page return. I was really helpful to see all the used ports in one list.
At first glance, Error: Dependencies lock file is not found in /home/runner/work/ansible-nas/ansible-nas. Supported file patterns: yarn.lock doesn't feel like something I did in this PR. I'll be glad to make any changes need to get past it, but I don't know how to solve it.
i think it would be better to let this be calibre and the existing calibre renamed to calibre-web.
i think it would be better to let this be
calibreand the existingcalibrerenamed tocalibre-web.
I agree. However that would break existing installations. I think avoiding breaking changes is more important than perfect naming.
I actually have a local branch that renames calibre-web just as you suggest. If the group decides that renaming is a better action, I can update that branch.
I agree, and would be happy to accept that as part of this PR 👍
On Thu, 6 Oct 2022, 16:23 cliff v, @.***> wrote:
i think it would be better to let this be calibre and the existing calibre renamed to calibre-web.
— Reply to this email directly, view it on GitHub https://github.com/davestephens/ansible-nas/pull/608#issuecomment-1270147484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFDGMFSXNYE4OSWH42XYQLWB3OF5ANCNFSM6AAAAAAQ5EPDS4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Rename done in new commit 1e3c150
I went with calibreweb because of YAML Syntax. To be consistent within Ansible-NAS, I also omitted the hyphen from the role and container names.
A note on transitioning the role name:
I had to manually remove the calibre docker container before running the playbook with the new role to clear port allocation. That should be a one time fix, but anyone using calibre-web may run into that error.
Any updates on this?
Merge conflict resolved.
MAssively late to the party but finally got this merged - thanks!