ansible-nas icon indicating copy to clipboard operation
ansible-nas copied to clipboard

Add: Calibre eBook Manager

Open eniad opened this issue 3 years ago • 8 comments

What this PR does / why we need it:

Add Calibre eBook Manager

Which issue (if any) this PR fixes:

Fixes #297

Any other useful info:

  1. I've been running this locally for about two months.
  2. Passing the security_opts into the docker container fixed this recent error: https://github.com/linuxserver/docker-calibre/issues/102. Glances and netdata are the only other roles to use security options.
  3. Verify I correctly added the molecule tests.
  4. The implementation of mounting - "{{ calibre_data_directory }}/data:/data" in roles/calibre/tasks/main.yml works, but it should be checked. The may be a better way to expose the Calibre Database Directory to the calibre docker container.
  5. I would like to see the application_ports page return. I was really helpful to see all the used ports in one list.

eniad avatar Oct 05 '22 03:10 eniad

At first glance, Error: Dependencies lock file is not found in /home/runner/work/ansible-nas/ansible-nas. Supported file patterns: yarn.lock doesn't feel like something I did in this PR. I'll be glad to make any changes need to get past it, but I don't know how to solve it.

eniad avatar Oct 06 '22 00:10 eniad

i think it would be better to let this be calibre and the existing calibre renamed to calibre-web.

powerdude avatar Oct 06 '22 14:10 powerdude

i think it would be better to let this be calibre and the existing calibre renamed to calibre-web.

I agree. However that would break existing installations. I think avoiding breaking changes is more important than perfect naming.

I actually have a local branch that renames calibre-web just as you suggest. If the group decides that renaming is a better action, I can update that branch.

eniad avatar Oct 06 '22 17:10 eniad

I agree, and would be happy to accept that as part of this PR 👍

On Thu, 6 Oct 2022, 16:23 cliff v, @.***> wrote:

i think it would be better to let this be calibre and the existing calibre renamed to calibre-web.

— Reply to this email directly, view it on GitHub https://github.com/davestephens/ansible-nas/pull/608#issuecomment-1270147484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFDGMFSXNYE4OSWH42XYQLWB3OF5ANCNFSM6AAAAAAQ5EPDS4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

davestephens avatar Oct 06 '22 18:10 davestephens

Rename done in new commit 1e3c150

I went with calibreweb because of YAML Syntax. To be consistent within Ansible-NAS, I also omitted the hyphen from the role and container names.

eniad avatar Oct 06 '22 18:10 eniad

A note on transitioning the role name:

I had to manually remove the calibre docker container before running the playbook with the new role to clear port allocation. That should be a one time fix, but anyone using calibre-web may run into that error.

eniad avatar Oct 06 '22 19:10 eniad

Any updates on this?

jakoblover avatar Dec 18 '23 17:12 jakoblover

Merge conflict resolved.

eniad avatar Dec 22 '23 15:12 eniad

MAssively late to the party but finally got this merged - thanks!

davestephens avatar Mar 14 '24 00:03 davestephens