vacuum icon indicating copy to clipboard operation
vacuum copied to clipboard

Couldn't start client vacuum

Open sk185050 opened this issue 1 year ago • 3 comments

[Error - 4:23:00 PM] Starting client failed Error: spawn EINVAL at ChildProcess.spawn (node:internal/child_process:421:11) at Object.spawn (node:child_process:799:9) at c:\Users<usename>.vscode\extensions\pb33f.vacuum-0.0.7\node_modules\vscode-languageclient\lib\node\main.js:383:40

sk185050 avatar Sep 02 '24 11:09 sk185050

can you provide the version of vacuum and nodeJS used , it might be related to nodeJs installation not sure if that is related ( https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2 )

so you may proceed an node ugrade , please share your result

LasneF avatar Sep 02 '24 14:09 LasneF

looks an issue in the way the vacuum is launched from vscode (and may be due to vscode update) @daveshanley is the vscode extension opensource , but the correction looks simple

we just need to add a dedicated parameter to make it back available on windows as mentionned in nodeJS doc

" It is important to note that there has been a breaking change for Windows users who utilize child_process.spawn and child_process.spawnSync. Node.js will now error with EINVAL if a .bat or .cmd file is passed to child_process.spawn and child_process.spawnSync without the shell option set. If the input to spawn/spawnSync is sanitized, users can now pass { shell: true } as an option to prevent the occurrence of EINVALs errors."

LasneF avatar Sep 03 '24 10:09 LasneF

mmm.. ok, will look into this asap.

daveshanley avatar Sep 03 '24 12:09 daveshanley