vacuum icon indicating copy to clipboard operation
vacuum copied to clipboard

Creating html-report from Vacuum report does not support custom rules

Open LittleGreenYoda42 opened this issue 1 year ago • 1 comments

When creating an html-report from a vacuum report, the html page only contains results for the default rules.

This is because when re-creating the nodes from the report data, the rule data is taken from the OpenAPIDefaultRuleSet and retrieved via the rule-id..

As custom rules are not contained in the default ruleset, the rule definition is nil. This has the effect that the function for getting rules by category will exclude the results for custom rules by checking that the rule must not be nil.

I guess one option could be to put the ruleset used for creating the report into the report as well. Another one to let the user hand in the same ruleset again when creating the html-report and reading from the vacuum report file. (although that feels strange)

LittleGreenYoda42 avatar Jul 25 '24 15:07 LittleGreenYoda42

This is a bug.

daveshanley avatar Jul 29 '24 14:07 daveshanley

Fixed in v0.17.11 Custom rules are now preserved.

daveshanley avatar Aug 30 '25 04:08 daveshanley