socialite icon indicating copy to clipboard operation
socialite copied to clipboard

Default generated password is weak

Open RicLeP opened this issue 6 years ago • 1 comments

https://github.com/daveozoalor/socialite/blob/ab751b9f4f0d1faf2458fc46c73719a87b8f46ee/app/Http/Controllers/Auth/TwitterController.php#L74

Once a user signs in with a social account the user table will include their email address and the password 1234 meaning anyone could easily guess the login. I know this is just an example for a course but people learning could use this as a guide and copy that into production.

RicLeP avatar Apr 18 '18 07:04 RicLeP

Thanks a lot for this. I assumed devs will know that already but I should have mentioned it in the tutorial.

On Apr 18, 2018 8:49 AM, "Richard Le Poidevin" [email protected] wrote:

https://github.com/daveozoalor/socialite/blob/ ab751b9f4f0d1faf2458fc46c73719a87b8f46ee/app/Http/Controllers/Auth/ TwitterController.php#L74

Once a user signs in with a social account the user table will include their email address and the password 1234 meaning anyone could easily guess the login. I know this is just an example for a course but people learning could use this as a guide and copy that into production.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/daveozoalor/socialite/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9rfAWzFjPNJqrwou_cwQqtPnwfC2Vgks5tpvAYgaJpZM4TZlN3 .

davepartner avatar Apr 18 '18 11:04 davepartner