Dave Young
Dave Young
#1009 is another example of how app health monitoring can be made better by bubbling up logs from the underlying parser to determine the cause of a channel closure or...
example log that appears in the application with the inclusion of #1009 : ``` logger.go:18] error reading /dev/kmsg: read /dev/kmsg: broken pipe ```
> So this is to watch the health of NPD itself instead of other applications, right? exactly yep. we run NPD as a daemonset on 20,000+ nodes. i can try...
should close #1003
Is CI okay? Looks like the same failure on my other PRs marked ok to test....
Yes I can take a look
@wangzhen127 looks like the tests passed here, are we good to request member review?
@wangzhen127 can I get an ok-to-test?
Try using env variables for these. Your syntax is close, you just need to prefix your variable names there: ${ENV:variable-name} Then all you need to do is make sure you...