phpmig icon indicating copy to clipboard operation
phpmig copied to clipboard

Migration::__construct() "final" key word decreases usability

Open daimaxiong opened this issue 4 years ago • 1 comments

The constructor's signature is final public function __construct()

I would like to make a base class for my migrations that extends Phpmig\Migration\Migration and does some custom configuration/initilization tasks.

The logical goto for that is the constructor, however, I cannot do that, because the parent class's constructor is marked final.

Please remove this in a future version

daimaxiong avatar Nov 22 '21 14:11 daimaxiong

I think the engine probably depends on the constructor being the way it is, hence the final. We'd need something more robust than just removing the final on the constructor.

davedevelopment avatar Nov 22 '21 16:11 davedevelopment