Dave Cramer

Results 500 comments of Dave Cramer

Interesting @bokken I believe you have some insight into this ?

So I guess the issues here is we don't know whether this is an array of bytes or a string?

> There is some ambiguity there, but /assuming/ an array of `bytea` seems reasonable enough in this scenario. if this is the case should we implement it this way ?

> Looking at JDBC docs, it doesn't restrict `elements` to be in either of the forms, so implementors must support both. Not sure I agree with this opinion; but I'm...

I think we are open to the implementation. Care to provide a PR ?

@hgschmie any reason not to provide a PR here ?

You'd think someone would have already done this?

Certainly the code is cleaner with the lambda.

There are a few places where you are changing logLevel to loggerLevel, but we removed loggerLevel in https://github.com/pgjdbc/pgjdbc/commit/09c2c37a6efd545a57974aec3ac1658a255b6907