commandcenter icon indicating copy to clipboard operation
commandcenter copied to clipboard

Bot doesn't check if a Refinery is on top of Geyser in BuildingPlacer

Open ghost opened this issue 8 years ago • 4 comments

Seems like the bot can't execute this strategy because he can't build reapers: "3Rax_Reapers" : { "Race" : "Terran", "OpeningBuildOrder" : ["SCV", "SupplyDepot", "SCV", "SCV", "SCV", "Refinery", "SCV", "Barracks", "SCV", "Refinery", "SCV", "Barracks", "SCV", "Barracks", "SCV", "SupplyDepot", "SCV", "SupplyDepot", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper", "Reaper"] }, And sometimes he builds extra refinery, sometimes not, also not clear why.

ghost avatar Aug 11 '17 00:08 ghost

I've fixed this in code but havent recompiled the binary release yet

The reason it may build an extra refinery is because you've specified 2 in the build-order, but I haven't correctly implemented expansion bases yet, so it may be buggy. Will update it as soon as I can

davechurchill avatar Aug 11 '17 01:08 davechurchill

I'm sorry, I said that not clear enough: as "extra refinery" I mean a second refinery in the main base, not something fancy like a refinery in the expansion. So in my turn it would be better to say: "and sometimes he builds second refinery, sometimes not. Not clear why".

ghost avatar Aug 11 '17 05:08 ghost

I believe it's because I don't currently check to see if there's a refinery on the geyser I've chosen. So the order in which I check them is through the iterator which may just be randomly ordered. I will fix this shortly, thanks!

davechurchill avatar Aug 11 '17 06:08 davechurchill

This bug has been fixed with #82.

ArtaSeify avatar Dec 16 '18 08:12 ArtaSeify