httpstat icon indicating copy to clipboard operation
httpstat copied to clipboard

Published 20 hours ago • verified publisher icon davecheney

Add Go 1.8 TLS tracing support & refactor timing code

Open rs opened this issue 6 years ago • 9 comments

To have accurate measurement of TLS and support skipped steps (DNS, TCP and TLS reuse), the timing code has been refactored to use Go 1.8 support for TLS tracing as well as a more descriptive variable namings for steps time.

This commit removes support for Go versions lower than 1.8.

rs avatar Apr 27 '18 20:04 rs

@davecheney: The failing test does also fail on master.

rs avatar Apr 27 '18 20:04 rs

@davecheney some tests are still failing, even after the fix. Apparently, httpbin has some connectivity issue. Please just relaunch the test.

rs avatar Apr 27 '18 20:04 rs

Done, tests are still randomly failing though.

rs avatar Apr 28 '18 06:04 rs

I've merged a few of the outstanding commits, can you please rebase and we'll see what's left.

davecheney avatar Apr 28 '18 09:04 davecheney

I think i've fixed the failing tests, please try again.

davecheney avatar Apr 28 '18 10:04 davecheney

httpbin is still failing from travis.

rs avatar Apr 30 '18 06:04 rs

@davecheney what about removing the httpbin tests? Could be replaced by a mock server.

rs avatar May 03 '18 18:05 rs

@davecheney any chance to merge this?

rs avatar May 25 '18 06:05 rs

@davecheney any chance to have a look at this? Thanks!

marco-m avatar Feb 02 '19 12:02 marco-m