discoverdotnet icon indicating copy to clipboard operation
discoverdotnet copied to clipboard

Published 20 hours ago • verified publisher icon daveaglick

Handle relative blog links

Open RemiBou opened this issue 5 years ago • 3 comments

This link to my blog post causes a 404 : https://discoverdot.net/Test-your-JSInterop-code-with-cypress/.

Here is my post link https://remibou.github.io/Test-your-JSInterop-code-with-cypress/ .

RemiBou avatar Jan 29 '20 10:01 RemiBou

It looks like the links on my feed are not absolute, I don't know if this is correct or not. This explain also why my feed is failing on dev.to

RemiBou avatar Jan 29 '20 10:01 RemiBou

I fixed it by removing feed.xml from my repo, it seems that if there is this file, Type On Strap overrides jekyll-feed. Now it's solved on the feed, I hope the link will be better. But maybe you should detect relative url in the RSS feed and make it absolute. I can work on a PR if you want.

RemiBou avatar Jan 29 '20 16:01 RemiBou

But maybe you should detect relative url in the RSS feed and make it absolute.

Totally agree. I'm going to reopen this issue to track that broader problem.

daveaglick avatar Jan 29 '20 16:01 daveaglick