FitVids.js icon indicating copy to clipboard operation
FitVids.js copied to clipboard

Does not work for Google Drive Embeds (included a codepen example)

Open ufo2mstar opened this issue 8 years ago • 1 comments

Hi @davatron5000 , Thanks for the cool plugin 👍 saved me some development time on my blog... But am facing issues with google drive embeds. Here is the codepen example of my issue: https://codepen.io/ufo2mstar/pen/EwMMxz

PS: If I may proffer a suggestion; the codepen issue guideline is a good idea.. a lesser threshold for entry would be a forkable working example showing how you wanted us bug loggers to put forward the example would make it easier on us 😄 maybe you can even remodel my own example if you like it.. Cheers!

ufo2mstar avatar Oct 21 '17 00:10 ufo2mstar

Update, I tried the the customSelector option that works.. hope this helps to fix the problem https://codepen.io/ufo2mstar/pen/EwMMxz

// does not work
$('iframe[src*="drive"]').parent().fitVids();
// does work 
$("#vid_div").fitVids({ customSelector: "iframe[src^='https://drive.google.com']"});

ufo2mstar avatar Oct 21 '17 04:10 ufo2mstar