rofi icon indicating copy to clipboard operation
rofi copied to clipboard

Matches in mode name of entry are highlighted, but not actually matched, in combi mode.

Open HactarCE opened this issue 7 years ago • 6 comments

Version

1.5.1-dirty (tags/1.5.1)

Configuration

Output of rofi -help

Launch Command

rofi -show combi

Steps to reproduce

  • Enable run mode as one of combi-modi

  • Run rofi -show combi

  • Type run into the prompt

  • Each entry contains the mode name (in this example, run) and the name of the program

What behaviour you see

  • Only entries where the name of the program contains run are selected, and the word run is highlighted in both the name of the program and mode name

What behaviour you expect to see

One of the following:

A:

  • Only entries where the name of the program contains run are selected, and the word run is hightlighted in only the name of the program

B:

  • Entries where either the name of the program or the mode name contains run are selected, and the word run is highlighted in both the name of the program and the mode name

Even better would be a configuration option to switch between the two behaviors.

HactarCE avatar Oct 07 '18 20:10 HactarCE

Yeah, the highlight is independent of the filtering (for speed issues). The highlight is on the visible text (not on searched fields). I hope to improve this in the future.

DaveDavenport avatar Oct 07 '18 20:10 DaveDavenport

Is there any way to get behavior B?

luxzeitlos avatar Oct 19 '20 18:10 luxzeitlos

It is not going to be trivial (at all) to fix the highlighting of the text in the current design, I don't expect this be changed soon. (beside possibly removing highlighting as it seems to cause confusion because of this reason.)

DaveDavenport avatar Oct 19 '20 18:10 DaveDavenport

@DaveDavenport I would like to have it the other way around. I would like to keep the highlighting but change the matching. So I want to be able to enter run firefox to start firefox (and not match a window)

luxzeitlos avatar Oct 19 '20 19:10 luxzeitlos

This is supported, see manpage. !r firefox

DaveDavenport avatar Oct 19 '20 19:10 DaveDavenport