rofi
rofi copied to clipboard
Minimize rebuilds on git version change
For now full rebuild happens when current commit changes, which may happen without actual content change - e.g. something is commited or uncommited via git reset
without --hard
option. This change makes only necessary files being rebuild - those, using GIT_REVISION.
@sardemff7 you added that option, any feedback on this.
I never had issues with this (But rofi compiles so quick, I would not have noticed anyway).
Seems like a good move, but you should put the #include
next to the nkutils one, in an #else
branch for line 50 #ifdef
Codecov Report
Merging #1316 (0614b9f) into next (04c006a) will increase coverage by
0.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## next #1316 +/- ##
==========================================
+ Coverage 32.98% 33.04% +0.06%
==========================================
Files 42 42
Lines 11934 12024 +90
==========================================
+ Hits 3936 3973 +37
- Misses 7998 8051 +53
Impacted Files | Coverage Δ | |
---|---|---|
source/rofi.c | 0.00% <ø> (ø) |
|
source/xcb.c | 0.00% <0.00%> (ø) |
|
source/view.c | 0.00% <0.00%> (ø) |
|
source/dialogs/drun.c | 0.00% <0.00%> (ø) |
|
test/theme-parser-test.c | 98.31% <0.00%> (+0.03%) |
:arrow_up: |
source/widgets/widget.c | 49.84% <0.00%> (+0.15%) |
:arrow_up: |
lexer/theme-lexer.l | 74.68% <0.00%> (+0.25%) |
:arrow_up: |
source/theme.c | 35.49% <0.00%> (+0.37%) |
:arrow_up: |
lexer/theme-parser.y | 63.97% <0.00%> (+0.56%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 04c006a...0614b9f. Read the comment docs.