lua-http doc/modules/http.websocket.md: Add usage example to websocket:each()

doc/modules/http.websocket.md: Add usage example to websocket:each()

Open hollunder opened this issue 7 years ago • 5 comments

Since it wasn't obvious to me how to use each() I figure it would be useful to have a little example in the documentation.

Jul 19 '18 08:07 hollunder

Coverage decreased (-1.7%) to 86.204% when pulling d06eb6ee3503a990b8e4c27a96722ee12265f229 on hollunder:master into 921e04d4a576dd3c31234513565c110cfdf5d022 on daurnimator:master.

Jul 19 '18 08:07 coveralls

I hope it's OK now, I'm new to the whole PR workflow (and not that well versed in git either).

Jul 19 '18 09:07 hollunder

I'm a bit worried about the usefulness of the example beyond the general use of an iterator. One of the original questions I had about it was what it actually iterates over and I can't confidently answer it now either. Nor does it show how to sensibly break out of this loop.

Jul 19 '18 11:07 hollunder

Do you want to edit your PR further? Or do you think it improves the current docs and should be merged?

Jul 30 '18 13:07 daurnimator

Ping @hollunder ?

Aug 23 '18 07:08 daurnimator

lua-http lua-http copied to clipboard

doc/modules/http.websocket.md: Add usage example to websocket:each()

lua-http
lua-http copied to clipboard