ldbus icon indicating copy to clipboard operation
ldbus copied to clipboard

Published 20 hours ago • verified publisher icon daurnimator

makefile: configurability

Open msva opened this issue 5 years ago • 2 comments

Added support for presetting PKG_CONFIG and LUA_LIBDIR by user. Added support for DESTDIR.

msva avatar Sep 22 '18 10:09 msva

As far as I know, there is no need for the change to ?= a user can already override. Happy to take the DESTDIR patch: could you separate it out?

daurnimator avatar Sep 23 '18 06:09 daurnimator

Yes, I can, but in my opinion, "first patch" is needed too: for now, user can only redefine values only by passing them to make, but setting their values, for example, by setting values in top-level Makefile will not work until there will be "set only if unset". So, I'd prefer that you merge patch "as-is", if you have no any objections :smile:

msva avatar Sep 24 '18 01:09 msva