datree icon indicating copy to clipboard operation
datree copied to clipboard

don't auto-delete rendered manifest (kustomize/helm)

Open eyarz opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. Today, when running datree with kustomize or helm, datree is rendering a manifest in the temp file, passes it for scanning, and deletes the rendered files

Describe the solution you'd like for easy debugging, it will be useful if the file will not be deleted

Describe alternatives you've considered rendering the manifest by myself

Additional context the default behavior is still to delete the file.

  • If the user passes the flag --save-rendered, the file will not be deleted from the temp dir
  • If the user passes the flag --save-rendered [path], the file will be created in %path%

eyarz avatar Aug 07 '22 16:08 eyarz

@eyarz should be one word --save-rendered

hadar-co avatar Aug 07 '22 18:08 hadar-co

my bad :) fixed.

eyarz avatar Aug 07 '22 19:08 eyarz

Can we close this issue? or is there any action item required for this? 🤔

amustaque97 avatar Oct 15 '22 10:10 amustaque97

@amustaque97 we are waiting for someone to grab this issue. This wasn't resolved yet.

eyarz avatar Oct 15 '22 19:10 eyarz

my bad :) fixed.

sorry I got confused because of the above comment from you @eyarz

amustaque97 avatar Oct 15 '22 21:10 amustaque97

The framework we use does not allow flags with triple meanings (true, false and %path%) therefor the flag will only have a boolean value, as in just --save-rendered and it will save the rendered file to the temp directory

shalev007 avatar Oct 27 '22 10:10 shalev007

Implemented.

eyarz avatar Nov 10 '22 08:11 eyarz