portaljs icon indicating copy to clipboard operation
portaljs copied to clipboard

UI of the Showcase pages: increase the width of the core page

Open Daniellappv opened this issue 1 year ago • 2 comments

Image

Acceptance

  • [ ] Side bar is moved to the left
  • [ ] TOC is moved to the right
  • [ ] The core page is wider now

Daniellappv avatar Jun 24 '24 07:06 Daniellappv

Increase the Width of the Core Content on Showcase Pages

Problem:

The core content on our Showcase pages is squeezed into a narrow middle section. This limits readability and the overall user experience. The left sidebar and the Table of Contents (ToC) on the right take up valuable space.

Appetite

This task can take from 2 to 6 hours

Solution

  • Increase the width of the core content area.
  • Fix the left sidebar to the left and the ToC to the right, ensuring they do not take up space from the core content.
  • Ensure responsiveness so that the layout adjusts appropriately on different screen sizes.

Desired Outcome

  • A wider core content area that enhances readability and provides a better user experience. The left sidebar and ToC remain accessible but do not encroach on the core content space.

Risks

  • Responsiveness: Ensure the new layout works well on different screen sizes, but avoid getting bogged down in perfecting every minor detail for less common devices.
  • Unfamiliar Codebase: Since I have not previously worked as a developer on this project, navigating the existing codebase might be challenging. Allocate extra time for understanding the current implementation and seek assistance from team members familiar with the project.

cc: @Daniellappv

willy1989cv avatar Jun 28 '24 10:06 willy1989cv

perfect and I think you can proceed @willy1989cv 😋

Daniellappv avatar Jun 28 '24 11:06 Daniellappv

@willy1989cv Let's use a 3-col layout from here https://tailwindui.com/components/application-ui/application-shells/multi-column It'll be much easier, and will solve the sidebar issues #1204 as well. It seems we must have broken the layout we picked from TaiwindUI in the past. Or maybe we used the one we had in Flowershow template. Can't remember now. But let's not waste more time on trying to make it work. Just use a ready working solution. Sorry, I wish I had realized this earlier...

olayway avatar Jul 09 '24 18:07 olayway

@olayway please review PR: https://github.com/datopian/datahub-next/pull/440

willy1989cv avatar Jul 15 '24 12:07 willy1989cv

Fixed

olayway avatar Jul 18 '24 16:07 olayway