giftless icon indicating copy to clipboard operation
giftless copied to clipboard

Wrap use of posixpath in an utility function

Open nOOb3167 opened this issue 4 years ago • 1 comments

Implement utility function, as suggested by comment on pull request #93.

nOOb3167 avatar Jul 19 '21 23:07 nOOb3167

Thanks, this is great. One small comment is that I'd rename the function to something more explicit like join_path to avoid confusion with general purpose str.join and the likes. join is a very generic name, and future me would surely get confused seeing it all over the code.

shevron avatar Sep 09 '21 06:09 shevron

@nOOb3167 i know this has been some time - we'd still happily have this in if modified as per comment. If you are now too busy just let us know and we'll look to add this ourselves at some point.

rufuspollock avatar Dec 25 '23 12:12 rufuspollock

Looks good. Will keep an eye on it, those conflicts seem simple to fix.

CC: @anuveyatsu

demenech avatar Jan 19 '24 12:01 demenech