flowershow icon indicating copy to clipboard operation
flowershow copied to clipboard

Multiline blockquotes support

Open olayway opened this issue 3 years ago • 3 comments

In Obsidian, you can create multiline blockquotes by returning at the end of the first line and starting the next one with > (which is added automatically in Obsidian by hitting enter while being on the end of the first line.)

Raw example:

> Roses are red,
> violets are blue.

How it renders in Obsidian: image

How it renders here on GitHub:

Roses are red, violets are blue.

How it renders in Flowershow: image

What works

Adding two spaces at the end of the first line.

Raw example:

> Roses are red,  
> violets are blue.

How it renders in Obsidian: image

How it renders here on GitHub:

Roses are red,
violets are blue.

How it renders in Flowershow: image

olayway avatar Jul 16 '22 17:07 olayway

That is correct (commonmark) markdown if no trailing space on first line. For github flavored markdown it should though not sure about how the gfm support in remark works.

Rose are red Violets are blue

A proper test would be the following which i think works.

> Rose are red
>
> Violets are blue

Rose are red

Violets are blue

Aside: good to add an example of the docs page for the relevant feature and see what happens.

rufuspollock avatar Jul 18 '22 11:07 rufuspollock

A proper test would be the following which i think works.

> Rose are red
>
> Violets are blue

Rose are red

Violets are blue

But the above lines end up separated by an additional empty line...

Since we are mostly targetting Obsidian users, I think this is worth taking into account how it works in Obsidian. (+ it seems to work the same here on GitHub, although I couldn't find confirmation for this in the GFM spec).

Aside: good to add an example of the docs page for the relevant feature and see what happens.

I've noticed it while working on such a page (demo for markdown/obsidian syntax support), but I'll add a link here after merge. But I've just updated the description of this issue, so should be more clear what happens.

olayway avatar Jul 18 '22 14:07 olayway

@olayway in tests here, it looks like it's working correctly, am I right?

image

Gutts-n avatar Sep 19 '23 01:09 Gutts-n